From 0dbedcb2f535cb5abc31f3db6fd3e21d04e9b7fe Mon Sep 17 00:00:00 2001 From: Salad Dais Date: Thu, 22 Jul 2021 23:58:17 +0000 Subject: [PATCH] Improve coverage --- .coveragerc | 2 ++ tests/base/test_capsclient.py | 2 +- tests/base/test_serialization.py | 4 ---- tests/proxy/integration/test_http.py | 7 ------- tests/proxy/test_commands.py | 2 +- tests/proxy/test_message_filter.py | 4 ---- tests/proxy/test_templates.py | 4 ---- 7 files changed, 4 insertions(+), 21 deletions(-) diff --git a/.coveragerc b/.coveragerc index 9243873..7979681 100644 --- a/.coveragerc +++ b/.coveragerc @@ -8,3 +8,5 @@ exclude_lines = if typing.TYPE_CHECKING: def __repr__ raise AssertionError + assert False + pass diff --git a/tests/base/test_capsclient.py b/tests/base/test_capsclient.py index 726c3e9..96e3acc 100644 --- a/tests/base/test_capsclient.py +++ b/tests/base/test_capsclient.py @@ -50,4 +50,4 @@ class TestCapsClient(unittest.IsolatedAsyncioTestCase): with self.assertRaises(KeyError): with self.caps_client.get("BadCap"): - pass + assert False diff --git a/tests/base/test_serialization.py b/tests/base/test_serialization.py index 1a9c30d..e663511 100644 --- a/tests/base/test_serialization.py +++ b/tests/base/test_serialization.py @@ -791,7 +791,3 @@ class SubfieldSerializationTests(BaseSerializationTest): self.assertEqual(ser.serialize(None, FooFlags.FOO), 1) self.assertEqual(ser.serialize(None, 3), 3) self.assertEqual(ser.serialize(None, 7), 7) - - -if __name__ == "__main__": - unittest.main() diff --git a/tests/proxy/integration/test_http.py b/tests/proxy/integration/test_http.py index ee401b1..b9e7d13 100644 --- a/tests/proxy/integration/test_http.py +++ b/tests/proxy/integration/test_http.py @@ -17,7 +17,6 @@ from hippolyzer.lib.proxy.addons import AddonManager from hippolyzer.lib.proxy.http_event_manager import MITMProxyEventManager from hippolyzer.lib.proxy.http_flow import HippoHTTPFlow from hippolyzer.lib.proxy.http_proxy import SerializedCapData -from hippolyzer.lib.proxy.message_logger import FilteringMessageLogger from hippolyzer.lib.proxy.sessions import SessionManager from hippolyzer.lib.proxy.test_utils import BaseProxyTest @@ -30,12 +29,6 @@ class MockAddon(BaseAddon): flow.metadata["touched_addon"] = True -class SimpleMessageLogger(FilteringMessageLogger): - @property - def entries(self): - return self._filtered_entries - - class HTTPIntegrationTests(BaseProxyTest): def setUp(self) -> None: super().setUp() diff --git a/tests/proxy/test_commands.py b/tests/proxy/test_commands.py index b1c0783..b6c2d90 100644 --- a/tests/proxy/test_commands.py +++ b/tests/proxy/test_commands.py @@ -52,4 +52,4 @@ class TestCommandHandlers(unittest.IsolatedAsyncioTestCase): class _BadCommandHandler: @handle_command("foobaz") def bad_command(self, session, region): - pass + assert False diff --git a/tests/proxy/test_message_filter.py b/tests/proxy/test_message_filter.py index 2509cff..f6850fb 100644 --- a/tests/proxy/test_message_filter.py +++ b/tests/proxy/test_message_filter.py @@ -128,7 +128,3 @@ class MessageFilterTests(unittest.IsolatedAsyncioTestCase): entry = HTTPMessageLogEntry(flow) self.assertTrue(self._filter_matches("FakeCap", entry)) self.assertFalse(self._filter_matches("NotFakeCap", entry)) - - -if __name__ == "__main__": - unittest.main() diff --git a/tests/proxy/test_templates.py b/tests/proxy/test_templates.py index 0971b52..aee8e28 100644 --- a/tests/proxy/test_templates.py +++ b/tests/proxy/test_templates.py @@ -67,7 +67,3 @@ class TemplateTests(unittest.TestCase): def test_textureentry_defaults(self): te = TextureEntry() self.assertEqual(UUID('89556747-24cb-43ed-920b-47caed15465f'), te.Textures[None]) - - -if __name__ == "__main__": - unittest.main()