Add note about attachment tp out / in brokenness

This commit is contained in:
Salad Dais
2021-05-07 04:49:49 +00:00
parent 8af87befbd
commit 60b39e27f8

View File

@@ -156,6 +156,12 @@ class ObjectManager:
del old_parent.Children[idx]
else:
# Something is very broken if this happens
# TODO: This seems to be triggered on attachments of avatars that left and re-entered
# the sim. This gets triggered because the LocalID of the existing object gets changed
# inside the handler because the object is looked up by FullID (which doesn't change
# when a prim leaves the sim.) Need to figure out the correct behaviour for this case.
# This was being masked before because the mutation of the `LocalID` was ignored inside
# `Object.update_properties()` as the field was `ID`, not `LocalID`.
LOG.warning(f"Changing parent of {obj.LocalID}, but old parent didn't correctly adopt, "
f"was {'' if removed else 'not '}in orphan list")
else: