From 60b39e27f8f77b7f47f9fc2f6015a2824ff24e52 Mon Sep 17 00:00:00 2001 From: Salad Dais Date: Fri, 7 May 2021 04:49:49 +0000 Subject: [PATCH] Add note about attachment tp out / in brokenness --- hippolyzer/lib/proxy/objects.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hippolyzer/lib/proxy/objects.py b/hippolyzer/lib/proxy/objects.py index 4911b73..96909f4 100644 --- a/hippolyzer/lib/proxy/objects.py +++ b/hippolyzer/lib/proxy/objects.py @@ -156,6 +156,12 @@ class ObjectManager: del old_parent.Children[idx] else: # Something is very broken if this happens + # TODO: This seems to be triggered on attachments of avatars that left and re-entered + # the sim. This gets triggered because the LocalID of the existing object gets changed + # inside the handler because the object is looked up by FullID (which doesn't change + # when a prim leaves the sim.) Need to figure out the correct behaviour for this case. + # This was being masked before because the mutation of the `LocalID` was ignored inside + # `Object.update_properties()` as the field was `ID`, not `LocalID`. LOG.warning(f"Changing parent of {obj.LocalID}, but old parent didn't correctly adopt, " f"was {'' if removed else 'not '}in orphan list") else: