From a11ef96d9a201079d9cdf9510859e92868e8dacc Mon Sep 17 00:00:00 2001 From: Salad Dais Date: Fri, 5 Jan 2024 02:53:05 +0000 Subject: [PATCH] Serve inbound Xfers reliably --- hippolyzer/lib/base/xfer_manager.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hippolyzer/lib/base/xfer_manager.py b/hippolyzer/lib/base/xfer_manager.py index 9847b78..dd3393f 100644 --- a/hippolyzer/lib/base/xfer_manager.py +++ b/hippolyzer/lib/base/xfer_manager.py @@ -269,12 +269,13 @@ class XferManager: xfer.xfer_id = request_msg["XferID"]["ID"] packet_id = 0 - # TODO: No resend yet. If it's lost, it's lost. while xfer.chunks: chunk = xfer.chunks.pop(packet_id) # EOF if there are no chunks left packet_val = XferPacket(PacketID=packet_id, IsEOF=not bool(xfer.chunks)) - self._connection_holder.circuit.send(Message( + # We just send reliably since I don't care to implement the Xfer-specific + # resend-on-unacked nastiness + _ = self._connection_holder.circuit.send_reliable(Message( "SendXferPacket", Block("XferID", ID=xfer.xfer_id, Packet_=packet_val), Block("DataPacket", Data=chunk),