Make client login testable

tests/base/test_xfer_transfer.py

@@ -6,7 +6,6 @@ from typing import *
 from hippolyzer.lib.base.datatypes import UUID
 from hippolyzer.lib.base.message.message import Block, Message
 from hippolyzer.lib.base.message.message_handler import MessageHandler
-from hippolyzer.lib.base.message.circuit import ConnectionHolder
 from hippolyzer.lib.base.templates import (
     AssetType,
     EstateAssetType,
@@ -16,26 +15,10 @@ from hippolyzer.lib.base.templates import (
     TransferTargetType,
     TransferStatus,
 )
-from hippolyzer.lib.proxy.circuit import ProxiedCircuit
 from hippolyzer.lib.base.network.transport import Direction
 from hippolyzer.lib.base.transfer_manager import TransferManager, Transfer
 from hippolyzer.lib.base.xfer_manager import XferManager
-
-
-class MockHandlingCircuit(ProxiedCircuit):
-    def __init__(self, handler: MessageHandler[Message, str]):
-        super().__init__(("127.0.0.1", 1), ("127.0.0.1", 2), None)
-        self.handler = handler
-
-    def _send_prepared_message(self, message: Message, transport=None):
-        loop = asyncio.get_event_loop_policy().get_event_loop()
-        loop.call_soon(self.handler.handle, message)
-
-
-class MockConnectionHolder(ConnectionHolder):
-    def __init__(self, circuit, message_handler):
-        self.circuit = circuit
-        self.message_handler = message_handler
+from hippolyzer.lib.base.test_utils import MockHandlingCircuit, MockConnectionHolder
 
 
 class BaseTransferTests(unittest.IsolatedAsyncioTestCase):

tests/client/test_hippo_client.py

@@ -0,0 +1,125 @@
+import asyncio
+import copy
+import unittest
+import xmlrpc.client
+from typing import Tuple, Optional
+
+import aioresponses
+
+from hippolyzer.lib.base.datatypes import UUID
+from hippolyzer.lib.base.message.circuit import Circuit
+from hippolyzer.lib.base.message.message import Message, Block
+from hippolyzer.lib.base.message.message_handler import MessageHandler
+from hippolyzer.lib.base.message.udpdeserializer import UDPMessageDeserializer
+from hippolyzer.lib.base.network.transport import AbstractUDPTransport, UDPPacket, Direction
+from hippolyzer.lib.base.test_utils import MockTransport, MockConnectionHolder
+from hippolyzer.lib.client.hippo_client import HippoClient, HippoClientProtocol
+
+
+class MockServer(MockConnectionHolder):
+    def __init__(self, circuit, message_handler):
+        super().__init__(circuit, message_handler)
+        self.deserializer = UDPMessageDeserializer()
+        self.protocol: Optional[HippoClientProtocol] = None
+
+    def process_inbound(self, packet: UDPPacket):
+        """Process a packet that the client sent to us"""
+        message = self.deserializer.deserialize(packet.data)
+        message.direction = Direction.IN
+        if message.reliable:
+            self.circuit.send_acks((message.packet_id,))
+        self.circuit.collect_acks(message)
+        if message.name != "PacketAck":
+            self.message_handler.handle(message)
+
+
+class PacketForwardingTransport(MockTransport):
+    def __init__(self):
+        super().__init__()
+        self.protocol: Optional[HippoClientProtocol] = None
+
+    def send_packet(self, packet: UDPPacket):
+        super().send_packet(packet)
+        self.protocol.datagram_received(packet.data, packet.src_addr)
+
+
+class MockServerTransport(MockTransport):
+    """Used for the client to send packets out"""
+    def __init__(self, server: MockServer):
+        super().__init__()
+        self._server = server
+
+    def send_packet(self, packet: UDPPacket) -> None:
+        super().send_packet(packet)
+        # Directly pass the packet to the server
+        packet = copy.copy(packet)
+        packet.direction = Direction.IN
+        # Delay calling so the client can do its ACK bookkeeping first
+        asyncio.get_event_loop_policy().get_event_loop().call_soon(lambda: self._server.process_inbound(packet))
+
+
+class MockHippoClient(HippoClient):
+    def __init__(self, server: MockServer):
+        super().__init__()
+        self.server = server
+
+    async def _create_transport(self) -> Tuple[AbstractUDPTransport, HippoClientProtocol]:
+        protocol = HippoClientProtocol(self.session)
+        # TODO: This isn't great, but whatever.
+        self.server.circuit.transport.protocol = protocol
+        return MockServerTransport(self.server), protocol
+
+
+class TestHippoClient(unittest.IsolatedAsyncioTestCase):
+    FAKE_LOGIN_URI = "http://127.0.0.1:1/login.cgi"
+    FAKE_LOGIN_RESP = {
+        "session_id": str(UUID(int=1)),
+        "secure_session_id": str(UUID(int=2)),
+        "agent_id": str(UUID(int=3)),
+        "circuit_code": 123,
+        "sim_ip": "127.0.0.1",
+        "sim_port": 2,
+        "region_x": 0,
+        "region_y": 123,
+        "seed_capability": "https://127.0.0.1:4/foo",
+    }
+
+    def setUp(self):
+        self.server_handler = MessageHandler()
+        self.server_transport = PacketForwardingTransport()
+        self.server_circuit = Circuit(("127.0.0.1", 2), ("127.0.0.1", 99), self.server_transport)
+        self.server = MockServer(self.server_circuit, self.server_handler)
+
+    def _make_fake_login_body(self):
+        return xmlrpc.client.dumps((self.FAKE_LOGIN_RESP,), None, True)
+
+    async def test_login(self):
+        client = MockHippoClient(self.server)
+
+        async def _do_login():
+            with aioresponses.aioresponses() as m:
+                m.post(self.FAKE_LOGIN_URI, body=self._make_fake_login_body())
+                await client.login("foo", "bar", login_uri=self.FAKE_LOGIN_URI)
+            await client.logout()
+
+        login_task = asyncio.create_task(_do_login())
+        with self.server_handler.subscribe_async(
+                ("*",),
+        ) as get_msg:
+            async def _get_msg_soon():
+                return await asyncio.wait_for(get_msg(), timeout=1.0)
+
+            assert (await _get_msg_soon()).name == "UseCircuitCode"
+            assert (await _get_msg_soon()).name == "CompleteAgentMovement"
+            self.server.circuit.send(Message(
+                'RegionHandshake',
+                Block('RegionInfo', fill_missing=True),
+                Block('RegionInfo2', fill_missing=True),
+                Block('RegionInfo3', fill_missing=True),
+                Block('RegionInfo4', fill_missing=True),
+            ))
+            assert (await _get_msg_soon()).name == "RegionHandshakeReply"
+            assert (await _get_msg_soon()).name == "AgentThrottle"
+            assert (await _get_msg_soon()).name == "LogoutRequest"
+
+        await login_task